use completionProvider and seperate value and key completion. - #67
Draft
srivastava-diya wants to merge 4 commits into
Draft
use completionProvider and seperate value and key completion.#67srivastava-diya wants to merge 4 commits into
srivastava-diya wants to merge 4 commits into
Conversation
srivastava-diya
commented
Aug 6, 2026
srivastava-diya
commented
Aug 6, 2026
| continue; | ||
| } | ||
|
|
||
| if (type === "number" || type === "integer") { |
Collaborator
Author
There was a problem hiding this comment.
skipping this for integer and number because there's nothing to show in the suggestion
Collaborator
There was a problem hiding this comment.
Just skipping sounds like it might be misleading. The user might be using those suggestions to know what to write next and if number/integer doesn't show up, they might think it's not allowed or not expected.
I wonder if it would be better to include those options, but just return a space.
Collaborator
Author
There was a problem hiding this comment.
i have removed the special if case for integer and number from the loop, now we just show options with label "number"/"integer" which returns a space
Screen.Recording.2026-08-08.032717.mp4
srivastava-diya
commented
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split into providers,
Completion.tsbecame a orchestrator soPropertyCompletion.tsandValueCompletion.tsbecame separate files.Capturing type as an annotation, removing
schemaStorelookup entirelyseperated
Completion.test.tsfile intoValueCompletion.test.tsandPropertyCompletion.test.ts